Fixed a bug which didn't allow proper comparison of objects #10089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhousel
added a commit
to facebook/Rapid
that referenced
this pull request
Apr 29, 2024
re: #1389 re: openstreetmap/iD#10089 re: openstreetmap/iD#9502 re: openstreetmap/iD#9788 This was tricky to track down, as iD#10089 doesn't actually fix the issue properly - really we should just not be using utilArrayIdentical with objects. I wrote some tests to actually cover this issue and ensure that's it is fixed correctly by comparing relation IDs.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9502
Resolves #9788
I know this is hack, but it's the simplest solution to this problem. You could compare key by key, but if you happen to have nested objects/nested arrays of objects, it will quickly turn into recursion hell.